This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
>> Please remove the Contributed line, we're not adding this anymore. Done and reattached. Please review, I'm going to submit SSE sincos for x86_64 after this patch merge. -- Liubov Dmitrieva 2012/8/13 Dmitrieva Liubov <liubov.dmitrieva@gmail.com>: >>> Did I miss something? > > Yes, I answered that comment in Bugzilla: > > http://sourceware.org/bugzilla/show_bug.cgi?id=14283 > > The bug was fixed. > > Today I've fixed some syntax issues in my x86_32 sinf/cosf patch: > >>> *ASM_TYPE_DIRECTIVE{,_PREFIX} was removed a few days ago (commit >>> b67e9372b28ef33). Please use ".type L(FOO),@object" instead. > >>> * Instead of defining EDOM, I suggest to: >>> #include <bits/errno.h> > >>> * For your comments, follow the usual style - with two spaces after "." >>> or "?" - and no space before > > and I reattached it. > > Change log hasn't changed: > > 2012-08-13 Liubov Dmitrieva <liubov.dmitrieva@gmail.com> > > * sysdeps/i386/i686/fpu/multiarch/Makefile: Update > (sysdep_routines): Add s_sinf-sse2, s_conf-sse2 > > * sysdeps/i386/i686/fpu/multiarch/s_sinf-sse2.S New file > * sysdeps/i386/i686/fpu/multiarch/s_cosf-sse2.S New file > * sysdeps/i386/i686/fpu/multiarch/s_sinf.c New file > * sysdeps/i386/i686/fpu/multiarch/s_cosf.c New file > * sysdeps/ieee754/flt-32/s_sinf.c Update > (SINF): Add macro for using routine as __sinf_ia32 > * sysdeps/ieee754/flt-32/s_cosf.c Update > (COSF): Add macro for using routine as __cosf_ia32 > > * sysdeps/i386/i686/fpu/multiarch/e_expf-sse2.S Fix Copyright > * sysdeps/i386/i686/fpu/multiarch/e_expf.c Fix Copyright > > > > -- > Liubov Dmitrieva > Intel Corporation > > 2012/8/10 Carlos O'Donell <carlos@systemhalted.org>: >> On Thu, Aug 9, 2012 at 4:13 AM, Dmitrieva Liubov >> <liubov.dmitrieva@gmail.com> wrote: >>> Repost of the patch with optimized Sinf and Cosf for x86_32. >>> We are looking forward to accepting and releasing this. >>> >>> http://sourceware.org/ml/libc-alpha/2012-06/msg00624.html >> >> I'm confused here. >> >> You didn't appear to answer any of Joseph's comments from June 22nd? >> >> http://sourceware.org/ml/libc-alpha/2012-06/msg00651.html >> >> Did I miss something? >> >> Cheers, >> Carlos.
Attachment:
sinf_cosf_x86_32.patch
Description: Binary data
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |