This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: invalid IFUNC DW_AT_linkage_name: memmove strstr time


> +/* Redefine strstr so that compiler won't complain the type mismatch
> +   from strong_alias below.  */

"Redefine strstr so that the compiler won't complain about the type
mismatch with the IFUNC selector in strong_alias, below."

> +/* Redefine time so that compiler won't complain the type mismatch
> +   from strong_alias below.  */

Similar fix.

> -void *time_ifunc (void) __asm__ ("time");
> +/* Avoid DWARF definition DIE on ifunc symbol so that GDB can handle
> +   ifunc symbol properly.  */
> +extern time_t __GI_time (time_t *);
> +void *time_ifunc (void) __asm__ ("__GI_time");

Can you make this __libc_time and let the __GI_* magic name
come from libc_hidden_def as normal?

> +/* Redefine memmove so that compiler won't complain the type mismatch
> +   from strong_alias below.  */

Needs similar grammar fixes as above.

> +/* Redefine strstr so that compiler won't complain the type mismatch
> +   from strong_alias below.  */

Likewise.


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]