This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH x86_64 only: optimize sinf and cosf with SSE2


On Thursday, August 09, 2012 12:16:06 Dmitrieva Liubov wrote:
> Repost of the patch with opimized SINF and COSF for x86_64.
> 
> http://sourceware.org/ml/libc-alpha/2012-06/msg00692.html
> 
> We are looking forward to accepting and releasing this.

Btw. if you could look at this bugreport as well and provide an 
optimized sincos implementation, it would be appreciated:
http://sourceware.org/bugzilla/show_bug.cgi?id=14412

Just a few comments on your submission:

* Please add a copyright header.
* Instead of defining EDOM, I suggest to:
#include <bits/errno.h>

* For your comments, follow the usual style - with two spaces after "." 
or "?" - and no space before

Could you make those changes and resubmit, please?

Thanks,
Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]