This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH roland/dirent64] clean up wordsize-64 struct dirent functions


On 8/2/2012 5:55 PM, Roland McGrath wrote:
> This patch is on the roland/dirent64 branch, which forks from the
> roland/off64_t branch (the patch won't apply to master).  It removes
> from sysdeps/wordsize-64 the various functions using 'struct dirent'
> and 'struct dirent64' where those types are identical.
>
> I added an __INO_T_MATCHES_INO64_T macro to bits/typesizes.h analogous
> to __OFF_T_MATCHES_OFF64_T.  Then sysdeps/unix/sysv/linux/bits/dirent.h
> (shared by all machines) defines _DIRENT_MATCHES_DIRENT64 if both
> __OFF_T_MATCHES_OFF64_T and __INO_T_MATCHES_INO64_T are defined, since
> the use of those types is the only difference between dirent and dirent64.
>
> As before, I've tested that no code changed on x86_64-linux-gnu.
> I think it should cover all wordsize-64 configurations, but they should
> be tested:
>         alpha, ia64, mips64, tilegx64, powerpc64, s390x, sparc64

Tested ok on tilegx64.

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]