This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] rpcgen - fall back to looking for cpp in system path


On Thursday, July 26, 2012 12:18:01 Allan McRae wrote:
> rpcgen currently looks for the C preprocessor in /lib/cpp and
> /usr/ccs/lib/cpp. This patch allows it to fall back to looking for the
> system cpp when neither of these are found.
> 
> 
> 2012-07-20	Allan McRae	<allan@archlinux.org>
> 
> 	[BZ #14303]
> 	* sunrpc/auth_des.c (find_cpp): Fall back to selecting system
> 	cpp when no found in defined paths
> 	* sunrpc/auth_des.c (open_input): Call cpp using execvp

You named the wrong filename in the changes entry. Please end sentences 
with a "." and don't repeat the filename, so something like:

	* sunrpc/rpc_main.c (find_cpp): Fall back to selecting system
 	cpp when no found in defined paths.
	(open_input): Call cpp using execvp.

I think we can remove the search for /usr/ccs/lib/cpp - this is not 
supported on an system glibc uses AFAIK. Could you make that additional 
change, please?

Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]