This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH,HURD] hurd: compliance fixes for getlogin_r
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Pino Toscano <toscano dot pino at tiscali dot it>
- Cc: bug-hurd at gnu dot org, libc-alpha at sourceware dot org
- Date: Fri, 20 Jul 2012 10:26:54 -0700 (PDT)
- Subject: Re: [PATCH,HURD] hurd: compliance fixes for getlogin_r
- References: <201204271244.03657.toscano.pino@tiscali.it><20120427221542.30FF02C0A3@topped-with-meat.com><201204281403.17912.toscano.pino@tiscali.it>
> > libc code can use C99 freely these days, so use an inline
> > initializing declaration rather than pre-declaring a new variable.
>
> Hm ok; is it bad if I leave them as it is, for now?
It's not terrible but there is no reason to let new code in that is not in
optimal style, and it's trivial to fix it. So please do that and then
the change is fine to commit.
Thanks,
Roland