This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Update sysdeps/x86_64/fpu_control.h


> +/* Macros for accessing the hardware control word.
> +
> +   Note that the use of these macros is no sufficient anymore with

"not sufficient"

> +   recent hardware.  Some floating point operations are executed in
> +   the SSE/SSE2 engines which have their own control and status register.  */
> +#define _FPU_GETCW(cw) __asm__ __volatile__ ("fnstcw %0" : "=m" (*&cw))
> +#define _FPU_SETCW(cw) __asm__ __volatile__ ("fldcw %0" : : "m" (*&cw))

Why *&?  That seems like a no-op.  There should be a comment explaining the
need for volatile.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]