This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][BZ #14188] Allow pthread_cleanup_push to build withcompilers other than gcc


On Sun, 3 Jun 2012 19:17:20 -0400, Carlos wrote:
> No. Notice that this is a public header. It is only in public headers
> where we care about the double-underscore name. 
> 
> We have made a conscious decision to use __glibc_* to avoid conflicts
> with the other components of the implementation.
> 
> Thus the use of __glibc_* is only required in public headers.

OK, I just thought it was much nicer to read compared to
__builtin_expect(cond, 0) and would hence be useful on a wider scale.

> This looks good to me.
> 

Thanks, I've pushed this now. I forgot to update NEWS in that commit,
so I pushed the NEWS update as a separate commit.

Regards,
Siddhesh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]