This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Remove use of INTDEF/INTUSE in csu


Roland McGrath <roland@hack.frob.com> writes:

>> Perhaps the __GI_ prefix should be produced by a macro.
>
> That does seem better.  But there are still some places where it might be
> difficult to do that, like syscalls.list entries.

syscalls.list entries get the __GI_ prefix automatically, always.  I'm
specially thinking about references to __GI_ names in assembler, in
places where HIDDEN_JUMPTARGET doesn't work.

>> @@ -54,6 +53,10 @@ extern DWtype __divdi3 (DWtype u, DWtype v);
>>  extern DWtype __moddi3 (DWtype u, DWtype v);
>>  extern UDWtype __udivdi3 (UDWtype u, UDWtype v);
>>  extern UDWtype __umoddi3 (UDWtype u, UDWtype v);
>> +libc_hidden_proto (__divdi3)
>> +libc_hidden_proto (__moddi3)
>> +libc_hidden_proto (__udivdi3)
>> +libc_hidden_proto (__umoddi3)
>
> What calls these from C so that we actually need these declarations?

Just so that I can use libc_hidden_ver.

>> @@ -22,8 +22,8 @@
>>     task which might not be worth it so we play tricks with the
>>     assembler.  */
>>  #if !defined __ASSEMBLER__ && !defined in_divdi3_c && !defined NOT_IN_libc && defined SHARED
>> -asm ("__divdi3 = __divdi3_internal");
>> -asm ("__udivdi3 = __udivdi3_internal");
>> -asm ("__moddi3 = __moddi3_internal");
>> -asm ("__umoddi3 = __umoddi3_internal");
>> +asm ("__divdi3 = __GI___divdi3");
>> +asm ("__udivdi3 = __GI___udivdi3");
>> +asm ("__moddi3 = __GI___moddi3");
>> +asm ("__umoddi3 = __GI___umoddi3");
>>  #endif
>
> Why don't these just use the definition names (__divdi3_compat or whatever)?

These are the names used by hidden_proto, but it doesn't really matter
which hidden alias we use.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]