This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Use x86-64 bits/byteswap.h for both i386 and x86_64
On Wed, May 30, 2012 at 1:30 PM, Roland McGrath <roland@hack.frob.com> wrote:
> I'd prefer to see this split up even smaller.
>
> byteswap-16.h isn't changing, so you can do that move alone in one change.
>
> Send another change making x86_64/bits/byteswap.h i386-compatible.
x86_64/bits/byteswap.h is i386-compatible. There is nothing to do.
> Then send another change just moving x86{_64,}/bits/byteswap.h without
> changing the contents at all.
That is exactly what my patch does.
> For all these things, I think that they should be done this way: first, a
> separate change that makes the x86_64 file fully compatible with i386;
Most if not x86_64 installed header files are compatible with i386.
> second, a change that just does the move and nothing else. ?For the pure
> file-moving changes, you can use git diff -M so that it's easy to see
> that it's a verbatim move.
>
--
H.J.