This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Remove pre-2.4 Linux kernel support
On 05/25/2012 04:41 PM, Joseph S. Myers wrote:
> On Tue, 22 May 2012, Joseph S. Myers wrote:
>
>> Tested x86. Could S390, SH and SPARC maintainers review / test the
>> changes to their ports, and someone review the patch as a whole?
>
> I don't think I've heard anything from S390 or SH maintainers about this
> patch <http://sourceware.org/ml/libc-alpha/2012-05/msg01605.html> - do you
> wish to review the changes for your architectures or test the patch on
> them, or should I just commit it without testing for those architectures?
>
>> * sysdeps/unix/sysv/linux/s390/s390-32/chown.c: Do not include
>> <kernel-features.h>.
>> [__ASSUME_32BITUIDS]: Make code unconditional.
>> [!__ASSUME_32BITUIDS]: Remove conditional code.
>> * sysdeps/unix/sysv/linux/s390/s390-32/lchown.c: Do not include
>> <kernel-features.h>.
>> [__ASSUME_32BITUIDS]: Make code unconditional.
>> [!__ASSUME_32BITUIDS]: Remove conditional code.
>
>> * sysdeps/unix/sysv/linux/sh/chown.c: Do not include
>> <kernel-features.h>.
>> [__ASSUME_32BITUIDS]: Make code unconditional.
>> [!__ASSUME_32BITUIDS]: Remove conditional code.
>
The S/390 changes look good to me. I've tested your patch on s390 and s390x. No regressions.
Thanks!
-Andreas-