This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: Generate lib-names.h and stubs.h from abi-*


On Thu, May 24, 2012 at 8:36 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, May 24, 2012 at 5:41 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Thu, May 24, 2012 at 5:14 PM, Roland McGrath <roland@hack.frob.com> wrote:
>>>> The only issue is ld=soname. ?I can try to remove the soname part
>>>> and use abi-ld-soname in CPU/Makefile instead.
>>>
>>> This is going in the wrong direction. ?It happens to be the case that
>>> all the other soname strings match for x86_64 and x32, but that is not
>>> something that the machinery should presume. ?(In the abstract, there
>>> is no good reason that x32 is using libc.so.6, for example--it's a new
>>> space of sonames and so it could be libc.so.1 instead. ?I imagine you
>>> want to keep them matching just so as not to surprise people, and that
>>> is reasonable enough. ?But that's certainly not something that we
>>> should be enforcing on people by having limiting assumptions in the
>>> build machinery.)
>>
>> The main issue is:
>>
>> http://www.sourceware.org/bugzilla/show_bug.cgi?id=14112
>>
>> When we generate lib-names.h, we need to see all variants
>> and select it properly base on abi variant. ?Without lib-names.h,
>> there is no issue.
>>
>
> This is what I checked in on hjl./abi branch. ?I moved alternate
> soname from shlib-versions to CPU/Makefile since it is also used
> to generate lib-names.h. ?Tested on Linux/x32, Linux/ia32 and
> Linux/x86-64. ?Any comments?
>
> Thanks.
>
>
> --
> H.J.
> ---
> ? ? ? ?* Makeconfig (default-abi): New macro.
> ? ? ? ?(abi-includes): Likewise.
> ? ? ? ?($(common-objpfx)soversions.mk): Remove WORDSIZE check. ?Use
> ? ? ? ?$(abi-$(default-abi)-lib-soname) for soname if defined.
> ? ? ? ?($(common-objpfx)gnu/lib-names.stmp): Generate from
> ? ? ? ?abi-variants.
> ? ? ? ?* Makefile (installed-stubs): Likewise.
> ? ? ? ?* include/stubs-biarch.h: Removed.
> ? ? ? ?* scripts/lib-names.awk: Only handle one library at a time.
> ? ? ? ?* scripts/soversions.awk: Remove WORDSIZE support.
> ? ? ? ?* shlib-versions: Remove WORDSIZE and ld entries.
> ? ? ? ?* sysdeps/unix/sysv/linux/Makefile (syscall-list-variants):
> ? ? ? ?Removed.
> ? ? ? ?(syscall-list-default-condition): Likewise.
> ? ? ? ?(syscall-list-default-condition): Likewise.
> ? ? ? ?(syscall-list-includes): Likewise.
> ? ? ? ?($(objpfx)bits/syscall%h $(objpfx)bits/syscall%d): Replace
> ? ? ? ?syscall-list-* with abi-*. ?Handle undefined abi-variants.
> ? ? ? ?* sysdeps/unix/sysv/linux/i386/Makefile (default-abi): New macro.
> ? ? ? ?* sysdeps/unix/sysv/linux/i386/Implies: New file.
> ? ? ? ?* sysdeps/unix/sysv/linux/x86/Makefile: Likewise.
> ? ? ? ?* sysdeps/unix/sysv/linux/x86_64/64/Makefile: Likewise.
> ? ? ? ?* sysdeps/unix/sysv/linux/x86_64/Implies: Add unix/sysv/linux/x86.
> ? ? ? ?* sysdeps/unix/sysv/linux/x86_64/Makefile (syscall-list-variants):
> ? ? ? ?Removed.
> ? ? ? ?(syscall-list-32-options): Likewise.
> ? ? ? ?(syscall-list-32-condition): Likewise.
> ? ? ? ?(syscall-list-64-options): Likewise.
> ? ? ? ?(syscall-list-64-condition): Likewise.
> ? ? ? ?* sysdeps/unix/sysv/linux/x86_64/x32/Makefile (default-abi): New
> ? ? ? ?macro.
> ? ? ? ?* sysdeps/unix/sysv/linux/powerpc/Makefile (syscall-list-*):
> ? ? ? ?Renamed to ...
> ? ? ? ?(abi-*): This.
> ? ? ? ?(abi-64-ld-soname): New macro.
> ? ? ? ?* sysdeps/unix/sysv/linux/s390/Makefile: Likewise.
> ? ? ? ?* sysdeps/unix/sysv/linux/sparc/Makefile (syscall-list-*):
> ? ? ? ?Renamed to ...
> ? ? ? ?(abi-*): This.
> ? ? ? ?* sysdeps/x86_64/64/shlib-versions: Remove ld entry.
> ? ? ? ?* sysdeps/x86_64/x32/shlib-versions: Likewise.
>

I rebased hjl/abi branch and mentioned BZ 14112 in
ChangeLog. David, can you try it on Sparc? Ryan,
can you try it on PPC?  Andreas, can you try it on
s390?

BTW, with sysdeps/unix/sysv/linux/x86 directory, we can
fix

http://sourceware.org/bugzilla/show_bug.cgi?id=14117

quite easily.

Thanks.


-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]