This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR libc/12495: Malloc fails if MALLOC_ALIGNMENT > 2 * SIZE_SZ


> 2012-03-14  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	PR libc/12495
> 	* malloc/malloc.c (sYSMALLOc): Don't update correction with
> 	front_misalign.
> 
> 2007-11-30  Daniel Jacobowitz  <dan@codesourcery.com>
> 
> 	PR libc/12495
> 	* malloc/malloc.c (SMALLBIN_CORRECTION): New.
> 	(MIN_LARGE_SIZE, smallbin_index): Use it to handle 16-byte alignment.
> 	(largebin_index_32_big): New.
> 	(largebin_index): Use it for 16-byte alignment.
> 	(sYSMALLOc): Handle MALLOC_ALIGNMENT > 2 * SIZE_SZ.

Merge these into one entry with the current date and both names.  I
think <drow@false.org> is the proper address to use for Daniel now,
but he can confirm.

Use "[BZ #12495]" as per convention.

I don't really understand the malloc code in sufficient detail to judge the
change without a lot of code-reading.  I'm pretty well willing to take your
and Daniel's word on it, but if someone else here can review it that
would be best.


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]