This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Remove pre-2.4 Linux kernel support
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: libc-alpha at sourceware dot org, Thomas Schwinge <thomas at codesourcery dot com>, Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>, "David S. Miller" <davem at davemloft dot net>, Andreas Krebbel <Andreas dot Krebbel at de dot ibm dot com>, Carlos O'Donell <carlos at systemhalted dot org>, Andreas Schwab <schwab at linux-m68k dot org>, Richard Henderson <rth at twiddle dot net>
- Date: Tue, 22 May 2012 21:55:34 +0000 (UTC)
- Subject: Re: Remove pre-2.4 Linux kernel support
- References: <Pine.LNX.4.64.1205222119020.8022@digraph.polyomino.org.uk><20120522212952.CEB7A2C0A9@topped-with-meat.com>
On Tue, 22 May 2012, Roland McGrath wrote:
> From a quick skim the changes look fine off hand. But please add a
> formulaic comment that is easily grepped for to each file where the
> change renders a function nothing but an INLINE_SYSCALL call.
To confirm:
/* Consider moving to syscalls.list. */
would be a suitable comment.
This also applies to files where there are calls to bounds-checking macros
for arguments to INLINE_SYSCALL, since the bounded-pointers code is
bitrotten.
This also applies to files where the only boilerplate around
INLINE_SYSCALL is for cancellation (none in this patch, but
sysdeps/unix/sysv/linux/poll.c and the powerpc64
pread/pwrite/pread64/pwrite64 from the 2.2 patch).
Files using INTERNAL_SYSCALL or INLINE_SETXID_SYSCALL cannot be converted
to syscalls.list (the former don't set errno, the latter have extra
processing in the threaded case).
On that basis, the following could have such a comment after the 2.2
patch:
sysdeps/unix/sysv/linux/poll.c
sysdeps/unix/sysv/linux/powerpc/chown.c
sysdeps/unix/sysv/linux/powerpc/powerpc64/pread.c
sysdeps/unix/sysv/linux/powerpc/powerpc64/pread64.c
sysdeps/unix/sysv/linux/powerpc/powerpc64/pwrite.c
sysdeps/unix/sysv/linux/powerpc/powerpc64/pwrite64.c
And the following after this patch:
sysdeps/unix/sysv/linux/i386/chown.c
sysdeps/unix/sysv/linux/i386/fchown.c
sysdeps/unix/sysv/linux/i386/getgroups.c
sysdeps/unix/sysv/linux/i386/getresgid.c
sysdeps/unix/sysv/linux/i386/getresuid.c
sysdeps/unix/sysv/linux/i386/lchown.c
sysdeps/unix/sysv/linux/s390/s390-32/chown.c
sysdeps/unix/sysv/linux/s390/s390-32/lchown.c
sysdeps/unix/sysv/linux/sh/chown.c
--
Joseph S. Myers
joseph@codesourcery.com