This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Add x32 dummy sysctl

> --- /dev/null
> +++ b/sysdeps/unix/sysv/linux/sysctl.mk
> @@ -0,0 +1,3 @@
> +ifeq ($(subdir),misc)
> +sysctl = sysctl
> +endif
[...]
> --- /dev/null
> +++ b/sysdeps/unix/sysv/linux/x86_64/x32/sysctl.mk
> @@ -0,0 +1,4 @@
> +# X32 doesn't support sysctl.
> +ifeq ($(subdir),misc)
> +sysctl =
> +endif

sysctl.mk is only used inside ifeq ($(subdir),misc).
So you don't need the conditionals.
linux/sysctl.mk does need a comment.

Otherwise the change looks good.


Thanks,
Roland
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]