This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] We no longer have foo.s files in the tree.
- From: Andreas Jaeger <aj at suse dot com>
- To: libc-alpha at sourceware dot org
- Cc: David Miller <davem at davemloft dot net>
- Date: Mon, 21 May 2012 11:00:33 +0200
- Subject: Re: [PATCH] We no longer have foo.s files in the tree.
- References: <20120520.215227.364024194063967625.davem@davemloft.net>
On Monday, May 21, 2012 03:52:27 David Miller wrote:
> Committed to master.
>
> * Makerules (sysd-rules): Remove .s from asm.
Thanks!
Is that really all?
I see rules like the following in our tree
./Makerules:$(objpfx)%$o: %.s $(before-compile); $$(compile-command.s)
./Makerules:$(objpfx)%$o: $(objpfx)%.s $(before-compile); $$(compile-
command.s)
Also sysdeps/unix/make-syscalls.sh tests for both .s and .S.
Could you clean those up as well, please?
Andreas
> ---
> Makerules | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makerules b/Makerules
> index 528077a..bce427d 100644
> --- a/Makerules
> +++ b/Makerules
> @@ -243,7 +243,7 @@ $(common-objpfx)sysd-rules:
> $(common-objpfx)config.make $(..)Makerules \ /*) ;;
\
> *) dir="\$$(..)$$dir" ;; \
> esac; \
> - asm='.S .s'; \
> + asm='.S'; \
> $(check-inhibit-asm) \
> for o in $(all-object-suffixes); do \
> set $(subst :, ,$(sysd-rules-patterns)); \
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126