This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix sunrpc static library


> 	* include/libc-symbols.h (libc_sunrpc_symbol): Define.

"New macro", please.

> 	* sunrpc/svc_simple.c: Support export of registerrpc for static
> 	library.
> 	* sunrpc/xcrypt.c: Support export of passwd2des for static
> 	library.

"Use it for registerrpc", please.

> +#ifdef LINK_OBSOLETE_RPC
> +/* Export symbol also for linking with static library. */

Two spaces after the sentence.  I'd say:

/* Export the symbol for both static and dynamic linking.  */

> +/* Export symbol only in shared libc. */

Two spaces here too.  And I'd say:

/* Export the symbol only for shared-library compatibility.  */

(The point being that it's not just that it's usable in the static library,
but also that it will have a default symbol version binding.)

Hmm.  Arguably this should be in shlib-compat.h instead, since
compat_symbol is only there.


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]