This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Flatten sysdeps/unix/bsd/bsd4.4 into sysdeps/unix/bsd


On Thu, 17 May 2012, David Miller wrote:

> Actually, my initial impression for this case is to simply rename the
> hppa/alpha foo.s files to foo.S and then remove the prefix rule case
> for .s entirely.
> 
> Is there something fundamental blocking that sort of change?

I'm not aware of anything fundamental, or any good reason we need both .S 
and .s sources.

There may of course be particular cases where preprocessing breaks the 
existing code and it needs adjusting to work as a .S file, but it should 
be straightforward for architecture maintainers to identify such cases and 
fix them as part of the .s -> .S renaming.  Carlos, Richard?

> Another observation for shorter-term fixes is that we could, early in
> the build, determine cases where we'll never end up using any of the
> files in a sysdep directory because an earlier sysdep dir always has a
> candidate.

I don't know how common that is, but the case of no sysdeps files at all 
in a directory now applies to sysdeps/unix/sysv and 
nptl/sysdeps/unix/sysv, and there are quite a few sysdeps directories with 
no .S files.

(As far as I know sysdeps source files always come directly from one of 
the sysdeps directories - there is no directory part in the name of the 
file searched for in each sysdeps directory.  For headers you have 
subdirectories such as sys/ and bits/ within the sysdeps directories.)

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]