Re: PATCH: Add tst-mallocalign1

[Andreas Jaeger <aj at suse dot com>]

On 05/17/2012 04:39 PM, H.J. Lu wrote:
> Hi,
>
> This patch adds tst-mallocalign1 to test malloc alignment.  Tested on
> Linux/x86-64.  OK to install?
>
> Thanks.
>
>
> H.J.
> ---
> 	* sysdeps/x86_64/Makefile (tests): Add tst-mallocalign1.
> 	* sysdeps/x86_64/tst-mallocalign1.c: New file.
>
> diff --git a/sysdeps/x86_64/Makefile b/sysdeps/x86_64/Makefile
> index 81c9128..d4525bc 100644
> --- a/sysdeps/x86_64/Makefile
> +++ b/sysdeps/x86_64/Makefile
> @@ -11,6 +11,10 @@ ifeq ($(subdir),gmon)
>   sysdep_routines += _mcount
>   endif
>
> +ifeq ($(subdir),malloc)
> +tests += tst-mallocalign1
> +endif
> +
>   ifeq ($(subdir),string)
>   sysdep_routines += cacheinfo strcasecmp_l-nonascii strncase_l-nonascii
>   gen-as-const-headers += locale-defines.sym
> diff --git a/sysdeps/x86_64/tst-mallocalign1.c b/sysdeps/x86_64/tst-mallocalign1.c
> new file mode 100644
> index 0000000..6b2a386
> --- /dev/null
> +++ b/sysdeps/x86_64/tst-mallocalign1.c
> @@ -0,0 +1,69 @@
> +/* Copyright (C) 2012 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Lesser General Public
> +   License as published by the Free Software Foundation; either
> +   version 2.1 of the License, or (at your option) any later version.
> +
> +   The GNU C Library is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   Lesser General Public License for more details.
> +
> +   You should have received a copy of the GNU Lesser General Public
> +   License along with the GNU C Library; if not, see
> +<http://www.gnu.org/licenses/>.  */
> +
> +#include<stdio.h>
> +#include<stdlib.h>
> +
> +/* Specified by x86-64 psABI.  */
> +#define ALIGN_MASK (16 - 1)
> +
> +void *
> +test (size_t s)
> +{
> +  void *p = malloc (s);
> +
> +  printf ("malloc: %d, %p: %ld\n", s, p,
> +	  ((unsigned long) p)&  ALIGN_MASK);

I get a warning now:
../sysdeps/x86_64/tst-mallocalign1.c:30:4: warning: format ‘%d’ expects 
argument of type ‘int’, but argument 2 has type ‘size_t’ [-Wformat]

Could you fix this, please?

Andreas

> +  return p;
> +}
> +
> +int
> +main (void)
> +{
> +  void *p;
> +  int ret = 0;
> +
> +  p = test (2);
> +  ret |= (unsigned long) p&  ALIGN_MASK;
> +  free (p);
> +
> +  p = test (8);
> +  ret |= (unsigned long) p&  ALIGN_MASK;
> +  free (p);
> +
> +  p = test (13);
> +  ret |= (unsigned long) p&  ALIGN_MASK;
> +  free (p);
> +
> +  p = test (16);
> +  ret |= (unsigned long) p&  ALIGN_MASK;
> +  free (p);
> +
> +  p = test (23);
> +  ret |= (unsigned long) p&  ALIGN_MASK;
> +  free (p);
> +
> +  p = test (43);
> +  ret |= (unsigned long) p&  ALIGN_MASK;
> +  free (p);
> +
> +  p = test (123);
> +  ret |= (unsigned long) p&  ALIGN_MASK;
> +  free (p);
> +
> +  return ret;
> +}


--
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126