Re: [PATCHv3] BZ#13750: Do not build manual in the source directory

[Andreas Jaeger <aj at suse dot com>]

On 05/02/2012 10:49 PM, Carlos O'Donell wrote:
> On Wed, May 2, 2012 at 4:30 PM, Andreas Jaeger<aj@suse.com>  wrote:
>> On 04/26/2012 05:09 PM, Andreas Jaeger wrote:
>>>
>>>
>>> Here's a updated patch to build the manual in the build directory and
>>> not anymore in the source directory.
>>>
>>> Tested with make;make info pdf html;make install;make clean
>>>
>>> Ok to commit?
>>
>>
>> Ping, is this ok to commit?
> 
> The patch is moving us in the right direction e.g. don't build in the
> source directory.
> 
> I have only done a cursory review of the patch, but I trust that if
> you built it and tested it and nothing broke that it's fine. We can
> fix any cosmetic makefile bike-shedding issues at a later date.
> 
> Have you reviewed how binutils and gdb do this or are they still
> building the manuals in the source tree? I remember fixing html/pdf
> builds for all the toolchain projects for CodeSourcery, and I remember
> ignoring this issue.
> 
> Please check this in on Friday if nobody else disagrees with me :-)

Thanks, done.

Btw. you might want to delete the generated files from your local source
 directory now - run "git status" to see what's extra.

I just run:
rm manual/version.texi manual/top-menu.texi manual/timeval_subtract.c.texi manual/texis manual/testpass.c.texi manual/testopt.c.texi manual/termios.c.texi manual/swapcontext.c.texi manual/summary.texi manual/subopt.c.texi manual/strncat.c.texi manual/strftim.c.texi manual/strdupa.c.texi manual/stpcpy.c.texi manual/stamp-version manual/stamp-summary manual/stamp-libm-err manual/sigusr.c.texi manual/sigh1.c.texi manual/setjmp.c.texi manual/select.c.texi manual/search.c.texi manual/rprintf.c.texi manual/add.c.texi manual/argp-ex1.c.texi manual/argp-ex2.c.texi manual/argp-ex3.c.texi manual/argp-ex4.c.texi  manual/atexit.c.texi manual/chapters.texi manual/db.c.texi manual/dir-add.texi manual/dir.c.texi manual/dir2.c.texi manual/execinfo.c.texi manual/filecli.c.texi manual/filesrv.c.texi manual/fmtmsgexpl.c.texi manual/genpass.c.texi manual/inetcli.c.texi  manual/inetsrv.c.texi manual/isockad.c.texi manual/libm-err.texi manual/longopt.c.texi manual/memopen.c.texi manual/memstrm.c.t
 exi manua
l/mkfsock.c.texi manual/mkisock.c.texi manual/mygetpass.c.texi manual/pipe.c.texi manual/popen.c.texi

Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126