This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/6] xstat: Add a pair of system calls to make extended file stats available
- From: Andreas Dilger <adilger at dilger dot ca>
- To: Dave Chinner <david at fromorbit dot com>
- Cc: David Howells <dhowells at redhat dot com>,linux-fsdevel at vger dot kernel dot org,linux-nfs at vger dot kernel dot org,linux-cifs at vger dot kernel dot org,samba-technical at lists dot samba dot org,linux-ext4 at vger dot kernel dot org,wine-devel at winehq dot org,kfm-devel at kde dot org,nautilus-list at gnome dot org,linux-api at vger dot kernel dot org,libc-alpha at sourceware dot org
- Date: Thu, 26 Apr 2012 21:11:21 -0600
- Subject: Re: [PATCH 1/6] xstat: Add a pair of system calls to make extended file stats available
- References: <5D4BF4AB-47E9-4E25-B2A3-F895C98BDAA3@dilger.ca> <20120419140558.17272.74360.stgit@warthog.procyon.org.uk> <20120419140612.17272.57774.stgit@warthog.procyon.org.uk> <18195.1335447156@redhat.com> <20120427005121.GD9541@dastard>
On 2012-04-26, at 6:51 PM, Dave Chinner wrote:
> On Thu, Apr 26, 2012 at 02:32:36PM +0100, David Howells wrote:
>> I wonder if there's a way to make this explicit - or is it something that if the bit isn't set, you can't use the value in st_blksize.
>> I wonder if this value always has to be non-zero to make sure existing
>> stat() doesn't explode.
>
> More likely it probably needs to be non-zero to prevent applications
> doing division by block size from exploding... ;)
Right, and any application which knows it needs the blocksize should
also be requesting it when using the statxat() (or whatever) syscall.
Cheers, Andreas