This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use __builtin_bswap32/64 in __bswap_32/64 for GCC >= 4.2
On Fri, Apr 6, 2012 at 4:18 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Apr 6, 2012 at 3:53 PM, Roland McGrath <roland@hack.frob.com> wrote:
>> Please clean the file up to use __GNUC_PREREQ everywhere.
>> That's much easier to follow.
>>
>> You're not just changing the behavior for GCC >= 4.2, which is what the log
>> entry says. ?You're also dropping the existing code for 2.0 <= GCC < 4.2.
>> That seems questionable. ?Please explain what effects this has on user code
>> compiled with e.g. GCC 4.1.
>>
>
> Here is the updated patch. ?I restored the code for GCC < 4.2. The patch
> is also available at:
>
> http://sourceware.org/git/?p=glibc.git;a=patch;h=9904dc47c88d9592ec66e5990754369bfde84c02
>
> OK to install?
>
PING.
--
H.J.