This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix bogus exceptions on exp(double)
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Aurelien Jarno <aurelien at aurel32 dot net>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 27 Mar 2012 22:51:41 +0000 (UTC)
- Subject: Re: [PATCH] Fix bogus exceptions on exp(double)
- References: <20120221135013.GA29215@hall.aurel32.net><Pine.LNX.4.64.1202220118280.22118@digraph.polyomino.org.uk>
On Wed, 22 Feb 2012, Joseph S. Myers wrote:
> On Tue, 21 Feb 2012, Aurelien Jarno wrote:
>
> > This patch fixes exp(double) triggering bogus underflow and overflow
> > exceptions. More details are in:
> >
> > http://sourceware.org/bugzilla/show_bug.cgi?id=13705
> >
> >
> > 2012-02-21 Aurelien Jarno <aurelien@aurel32.net>
> >
> > [BZ #13705]
> > * sysdeps/ieee754/dbl-64/w_exp.c(__exp): Use __kernel_standard
> > instead of __kernel_standard_f.
>
> This seems pretty obvious as fixing something that's clearly using the
> wrong API to use the right one - but shouldn't there be a test added to
> the testsuite for this bug, if it isn't triggered by existing tests?
Aurelien, ping regarding producing a version of the patch with a testcase
so it can go in. Since I added support for libm-test.inc testing overflow
exceptions in <http://sourceware.org/ml/libc-alpha/2012-03/msg00776.html>,
it should be easy to add a test to libm-test.inc that fails before your
w_exp.c patch and passes after it.
--
Joseph S. Myers
joseph@codesourcery.com