This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Add x32 support to dynamic linker audit
On Wed, Mar 21, 2012 at 2:27 PM, Carlos O'Donell
<carlos@systemhalted.org> wrote:
> On Wed, Mar 21, 2012 at 5:12 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>> The meaning of ptrdiff_t is very specific.
>>>
>>> I know that I'm outside of your original patch and that the code
>>> in question is not code specifically related to x32.
>>>
>>> Do you see anything wrong with changing all of these %t's to
>>> %lx and cast to uint64_t?
>>
>> I don't see anything wrong with that. I tried to minimize my
>> changes.
>
> Please clean this up to avoid using %t and ptrdiff_t.
>
> We should be printing variants of %x.
>
%lx is wrong for uint64_t, which may be long long, not
long.
>>>>
>>>> #define La_x32_regs La_x86_64_regs
>>>> #define ?La_x32_retval ?La_x86_64_retval
>>>>
>>>> work for you?
>>>
>>> Yes, as long as the names are consistent with the function being
>>> called e.g. La_x32_regs is used with la_gnu_x32_pltenter and
>>> la_gnu_x32_pltexit.
>>>
>>
>> I will make the change.
I am using:
typedef La_x86_64_regs La_x32_regs;
typedef La_x86_64_retval La_x32_retval;
> Thanks!
>
> I'll give your change a final review once I see the patch.
>
> Cheers,
> Carlos.
--
H.J.