This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Enhance fphex test
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: Marek Polacek <polacek at redhat dot com>, Roland McGrath <roland at hack dot frob dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 7 Mar 2012 21:40:19 -0500
- Subject: Re: [PATCH] Enhance fphex test
- References: <20120307230233.GF3171@redhat.com>
On Wed, Mar 7, 2012 at 6:02 PM, Marek Polacek <polacek@redhat.com> wrote:
> This patch extends the tst-fphex.c test so now it can be reused for
> testing also widechars using wprintf et al. ?Regtested on
> x86_64-linux, ok for trunk?
>
> 2012-03-07 ?Marek Polacek ?<polacek@redhat.com>
>
> ? ? ? ?[BZ #13806]
> ? ? ? ?* stdio-common/Makefile (tests): Add tst-fphex-wide.
> ? ? ? ?* stdio-common/tst-fphex.c: Define a few macros to make the
> ? ? ? ?test reusable. ?Use them.
> ? ? ? ?* stdio-common/tst-fphex-wide.c: New file.
Marek,
This looks good to me, thanks for adding a new test case. Please check this in.
Roland,
I noticed stdio-common/tst-fphex.c has no license.
What's up with test cases that don't have licenses?
Should they?
Cheers,
Carlos.