This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: include sys/param.h in getcwd.c
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: Mike Frysinger <vapier at gentoo dot org>, libc-alpha at sourceware dot org
- Date: Wed, 15 Feb 2012 10:47:06 -0800 (PST)
- Subject: Re: include sys/param.h in getcwd.c
- References: <200606180250.19479.vapier@gentoo.org><Pine.LNX.4.64.1202151807050.1671@digraph.polyomino.org.uk>
> I came across this 2006 patch
> <http://sourceware.org/ml/libc-alpha/2006-06/msg00068.html> in the course
> of reviewing bugs. I think it should go in as an obvious fix - source
> files should use well-defined APIs of the headers they include rather than
> relying on long indirect include paths for internal headers. Comments?
Yes, including directly what you actually use is just common sense.