This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] vfprintf: validate nargs and maybe allocate from heap


Thanks, that patch looks good to me; I don't see any technical
problems with it.  One minor stylistic nit that I didn't
notice last time:

> +    bytes_per_arg = sizeof (*args_value) + sizeof (*args_size)
> +                    + sizeof (*args_type);

The typical GNU style is to put parentheses around expressions that cross
line boundaries like that, e.g.,:

    bytes_per_arg = (sizeof (*args_value) + sizeof (*args_size)
                     + sizeof (*args_type));

This works better with Emacs.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]