Re: PATCH: generic/fcntl.h [was Re: asm-generic/unistd.h and glibcuse of NR_ipc]

[Chris Metcalf <cmetcalf at tilera dot com>]

On 3/11/2011 12:40 PM, Linas Vepstas wrote:
> Chris,
>
> Another patch, to generic/fcntl.h, at bottom.

This looks fine.  I haven't moved our internal code forward to 2.13 yet, so
I haven't hit it.  Another good argument to get this stuff merged up to the
main tree :-)

Removing LKML from the cc's since I doubt they care about glibc internals.

> [...]
>
> glibc-2.13 breaks without F_GETPIPE_SZ
>
> Closer inspection shows that F_DUPFD_CLOEXEC is usually
> protected by __USE_XOPEN2K8 and not __USE_GNU so
> I tweaked that; revert if you disagree ...
>
> In lieu of the usual changelog entry ---
> Signed-off-by: Linas Vepstas <linasvepsts@gmail.com>
>
> ---
>  sysdeps/unix/sysv/linux/generic/bits/fcntl.h |    4 ++++
>  1 file changed, 4 insertions(+)
>
> Index: glibc-2.13/sysdeps/unix/sysv/linux/generic/bits/fcntl.h
> ===================================================================
> --- glibc-2.13.orig/sysdeps/unix/sysv/linux/generic/bits/fcntl.h
>  2011-03-11 11:11:12.000000000 -0600
> +++ glibc-2.13/sysdeps/unix/sysv/linux/generic/bits/fcntl.h
> 2011-03-11 11:12:26.000000000 -0600
> @@ -114,6 +114,10 @@
>  # define F_SETLEASE    1024    /* Set a lease.  */
>  # define F_GETLEASE    1025    /* Enquire what lease is active.  */
>  # define F_NOTIFY      1026    /* Request notfications on a directory.  */
> +# define F_SETPIPE_SZ   1031  /* Set pipe page size array.  */
> +# define F_GETPIPE_SZ   1032  /* Set pipe page size array.  */
> +#endif
> +#ifdef __USE_XOPEN2K8
>  # define F_DUPFD_CLOEXEC 1030  /* Duplicate file descriptor with
>                                    close-on-exit set.  */
>  #endif

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com