This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: i386 port of the pthread library probes


The i386 code looks fine to me on its face.  I didn't check all the
assembly code to see if the probe parameters are the right things.
But that can be tested later by writing a stap test suite that makes
use of all the probe arguments and verifies their expected values.  I
also didn't check if you got every .S and .h file that you should, but
you can double-check that.  Note there are i486, i586, and i686
variants of several such files.  If you send me that patch on its own
with ChangeLog entries, I will merge that when I merge the x86_64 code.


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]