This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PowerPC64 - Fix INTERNAL_[V]SYSCALL_NCS macros to notcast return val to (int)


There are some extraneous parens in several places, but that doesn't matter
much.  The test fails to check for malloc failure.  If it does fail, writev
will either fail with EFAULT or crash anyway, so that is no critical.  The
return value from main on failure should be just 1 or 2 or something, not
what might be an arbitrary large number.

Otherwise the test looks good to me now.

I don't know if the actual fix in the powerpc code might have some other
ramifications and someone else would have to say about that.  Since the
other syscall macros return a long int value, I assume it's probably fine.


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]