This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Accidental checkin?


On Tue, Dec 14, 2010 at 8:39 AM, Andreas Schwab <schwab@redhat.com> wrote:
> "H.J. Lu" <hjl.tools@gmail.com> writes:
>
>> On Tue, Dec 14, 2010 at 7:47 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>> On Tue, Dec 14, 2010 at 5:42 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>>> Hi,
>>>>
>>>> Commit 42acbb92c861e97a6e1293ea853db88342a1bf53:
>>>>
>>>> http://sourceware.org/git/?p=glibc.git;a=commit;h=42acbb92c861e97a6e1293ea853db88342a1bf53
>>>>
>>>> changed
>>>>
>>>> sysdeps/i386/i686/multiarch/strcmp.S
>>>>
>>>> without ChangeLog entry. ?Is that an accidental checkin?
>>>>
>>>
>>> This change caused:
>>>
>>> http://sourceware.org/bugzilla/show_bug.cgi?id=12318
>>>
>>
>> That change has a typo.
>
> It is bogus in its entirety. ?It uses a call clobbered register around a
> function call.

That is why my ia32 system crashes at random :-).

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]