This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC][PATCH] make PowerPC64 default to nonexecutable stack
- From: Ulrich Drepper <drepper at gmail dot com>
- To: rsa at us dot ibm dot com
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 2 Nov 2010 23:36:44 -0400
- Subject: Re: [RFC][PATCH] make PowerPC64 default to nonexecutable stack
- References: <1288726319.26646.114.camel@localhost.localdomain>
Putting a definition in a common header only really makes sense if the
value will be changed at some point or you can make a change in one
place only. Neither is the case here. Just add the definition in
each header. It's not going to change and it is a machine-specific
value.
Also, no reason to use a symbol in the reserved namespace.
stackinfo.h is not installed. Use DEFAULT_STACK_PERMS or something
like that.
And why that configure override? If you say it's not needed and gcc
doesn't generate it, why should this change? Seems to be completely
unnecessary.