This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 1/2] Avoid duplication of _CLOEXEC and _NONBLOCK values
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: Guy Martin <gmsoft at tuxicoman dot be>
- Cc: libc-alpha at sourceware dot org, joseph at codesourcery dot com, davem at davemloft dot net
- Date: Tue, 24 Aug 2010 15:30:34 -0400
- Subject: Re: [PATCH v2 1/2] Avoid duplication of _CLOEXEC and _NONBLOCK values
- References: <1282568140-23330-1-git-send-email-gmsoft@tuxicoman.be>
On Mon, Aug 23, 2010 at 8:55 AM, Guy Martin <gmsoft@tuxicoman.be> wrote:
> The following patch adds bits/kernel-defines.h which defines __O_NONBLOCK and
> __O_CLOEXEC. The files in bits and sys redefining _CLOEXEC and _NONBLOCK have
> been updated to include this new file and use it's values.
> This allows arch with different values in the kernel to only copy
> bits/kernel-defines.h and not all the headers.
> In libc, sparc will benefit from it. In libc-ports, mips, alpha and hppa will.
>
> Compared to the initial patch, this v2 doesn't pollute name space and only adds
> a single small file. This file can probably be extended later for other arch
> specific values.
Guy,
Could you please move your patch to ports, that way the ports machine
maintainers can use these changes to minimize their maintenance
burden?
The approach used by this patch has already been rejected by Ulrich
Drepper. Please make sure you read all of Ulrich's comments.
http://sourceware.org/ml/libc-alpha/2010-08/msg00040.html
http://sourceware.org/ml/libc-alpha/2010-08/msg00041.html
I suggest we take this discussion to libc-ports and talk about how
your patch can be used in the ports tree.
Cheers,
Carlos.