This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Properly handle STT_GNU_IFUNC symbols in do_sym

From: "H.J. Lu" <hjl dot tools at gmail dot com>
To: Petr Baudis <pasky at suse dot cz>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Thu, 5 Nov 2009 19:14:49 -0700
Subject: Re: PATCH: Properly handle STT_GNU_IFUNC symbols in do_sym
References: <20091101173418.GA4324@lucon.org> <20091106020607.GF3708@machine.or.cz>

On Thu, Nov 5, 2009 at 7:06 PM, Petr Baudis <pasky@suse.cz> wrote:
> ?Hi!
>
> On Sun, Nov 01, 2009 at 09:34:18AM -0800, H.J. Lu wrote:
>> do_sym should use DL_FIXUP_VALUE_XXX macros to call IFUNC function.
>> Otherwise, it won't compile on ia64. This patch fixes it and adds
>> a test.
>
> ?BTW, are you sure the ifunc implementation in elf/dl-runtime.c is
> correct on IA64? It seems to use struct fdesc * as function pointer, I
> think it should use DL_FIXUP_VALUE_CODE_ADDR () instead.
>

We will fix any IFUNC problems when it is implemented on ia64.
Right now, it is OK on ia64 as long as it compiles.

-- 
H.J.

References:
- PATCH: Properly handle STT_GNU_IFUNC symbols in do_sym
  - From: H.J. Lu
- Re: PATCH: Properly handle STT_GNU_IFUNC symbols in do_sym
  - From: Petr Baudis

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]