Re: onwards to git

[Thomas Schwinge <tschwinge at gnu dot org>]

Hello!

On Mon, May 11, 2009 at 10:49:32PM +0200, Jim Meyering wrote:
> I've converted the trunk and all branches, filtering
> to aggregate commits, and cleaning up by removing empty commits
> and applying heuristics to use reasonable commit messages
> derived from ChangeLog entries.

This indeed looks very nice in the vast majority of cases!  I'm sure
there are a number of people who are interested in seeing the scripts and
techniques you used.  I am, for sure.  :-)


In case that you go over it again, here are three things you may want to
consider, or, of course, declare that they don't matter too much:

You may want to have your script filter out duplicate bugzilla ids, like
in 66ade7948c17d0d5d2b624226b81805a169747dd: ``[BZ #4465, BZ #4465, BZ
#4465, BZ #4465, BZ #4465]''.  But that is completely a minor thing.


Another thing I noticed by pure chance: around / with
cvs/glibc-2_6-branch there is an out-of-order commit:

    RMG 2007-07-10 02:39:31 518d13d01b384f9ba702f6e18aa8af478838e8c6
    UD  2007-07-09 18:12:05 0935b78139037f52f204ee1a66e095e616403e65
    JJ  2007-07-31 15:39:49 3bc457a5d8a75d82213e3cd7b20219dedcd6fe09
    UD  2007-07-09 18:11:50 85b0053cd3d3d92de8088974c97a934f2c0ce981

The 3bc45 commit introduces a huge amount of changes that are undone in
the 0935b one again:

    $ git diff 85b00..0935b --stat
     ChangeLog |    5 +++++
     1 files changed, 5 insertions(+), 0 deletions(-)

I did not systematically search for other problems like this.


The branch-off for cvs/glibc-2_10-branch is done too early; this is a
problem with the
sysdeps/unix/sysv/linux/powerpc/powerpc*/power6/fpu/*context.S files:
compare commit 1a345b10310e0290d5b2e0030acf148e496cefcb to
e54e51a1929135737ee49bc4bbf57bfee00a8eab -- which should be the same.


Regards,
 Thomas

Attachment: signature.asc
Description: Digital signature