This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] S/390: Fix 32/64 bit utmp compat problem v5

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Some more things:

- - the functions getutid_r32 should be named getutid32_r.  Always keep
the _r suffix since it is meaningful by itself.  _r32 means nothing.
There are a whole bunch of functions like this.

- - when malloc fails it already has set errno to ENOMEM.  There is no
reason to do this again.


I've made these changes myself and checked in the patch.

- --
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkiLYk0ACgkQ2ijCOnn/RHSSrQCgj8pt/pbS/DlAER6eP1/1Mm0t
CrcAn1OvhOM2zRhPMzvq+nv4aki6CLIh
=TSE+
-----END PGP SIGNATURE-----
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]