This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] remove useless if-before-free tests, take 2


Ulrich Drepper <drepper@redhat.com> wrote:
> Jim Meyering wrote:
>> Finally, here are ChangeLog entries, too:
>> (template automatically generated with vc-chlog)
>
> Check the automatic ChangeLog entry.  This script/program didn't get it
> right this time.  I fixed it and check the patch in.

Thanks for the heads-up.
vc-chlog relies on ctags (exuberant ctags in this case),
and this may indicate a bug in the latter, since I see no indication
that it is expected to misbehave on K&R-style function definitions.

    $ cat knr.c
    libc_hidden_def (glob)

    void
    globfree (pglob)
         register glob_t *pglob;
    {
      for (i = 0; i < pglob->gl_pathc; ++i) ;
    }
    $ ctags-exuberant -x knr.c
    libc_hidden_def  function      1 knr.c            libc_hidden_def (glob)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]