Re: [PATCH]: Add proper backtrace functions for sparc.

[David Miller <davem at davemloft dot net>]

From: David Miller <davem@davemloft.net>
Date: Fri, 09 May 2008 05:23:45 -0700 (PDT)

Ping?

> This allows the fortify testcases under debug/ to pass on sparc.
> 
> After all of the patches I've posted recently are applied, the only
> testcase failure left for sparcv9*-linux and sparc64*-linux is nptl's
> tst-cancelx21 on 64-bit.  That's probably just another missing
> -fexceptions for some part of the build and I'll try to track that
> down tomorrow.
> 
> Plain sparc-linux has a few other failures, but I think those are due
> to some futex issues when true atomics are not available as the
> testcases that fail simply hang in some futex call.
> 
> Please apply, thanks!
> 
> 2008-05-09  David S. Miller  <davem@davemloft.net>
> 
> 	* sysdeps/sparc/sparc32/backtrace.c: New file.
> 	* sysdeps/sparc/sparc64/backtrace.c: New file.
> ---
>  sysdeps/sparc/sparc32/backtrace.c |   55 +++++++++++++++++++++++++++++++++++
>  sysdeps/sparc/sparc64/backtrace.c |   58 +++++++++++++++++++++++++++++++++++++
>  2 files changed, 113 insertions(+), 0 deletions(-)
>  create mode 100644 sysdeps/sparc/sparc32/backtrace.c
>  create mode 100644 sysdeps/sparc/sparc64/backtrace.c
> 
> diff --git a/sysdeps/sparc/sparc32/backtrace.c b/sysdeps/sparc/sparc32/backtrace.c
> new file mode 100644
> index 0000000..e2357eb
> --- /dev/null
> +++ b/sysdeps/sparc/sparc32/backtrace.c
> @@ -0,0 +1,55 @@
> +/* Return backtrace of current program state.
> +   Copyright (C) 2008 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +   Contributed by David S. Miller <davem@davemloft.net>
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Library General Public License as
> +   published by the Free Software Foundation; either version 2 of the
> +   License, or (at your option) any later version.
> +
> +   The GNU C Library is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   Library General Public License for more details.
> +
> +   You should have received a copy of the GNU Library General Public
> +   License along with the GNU C Library; see the file COPYING.LIB.  If not,
> +   write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
> +   Boston, MA 02111-1307, USA.  */
> +
> +#include <execinfo.h>
> +#include <stddef.h>
> +#include <bp-checks.h>
> +#include <sys/trap.h>
> +
> +struct layout
> +{
> +  unsigned long locals[8];
> +  unsigned long ins[6];
> +  struct layout *__unbounded next;
> +  void *__unbounded return_address;
> +};
> +
> +int
> +__backtrace (void **array, int size)
> +{
> +  struct layout *current;
> +  int count;
> +
> +  asm volatile ("ta %0" : : "i" (ST_FLUSH_WINDOWS));
> +  asm volatile ("mov %%fp, %0" : "=r"(current));
> +  current = BOUNDED_1 (current);
> +
> +  for (count = 0; count < size; count++)
> +    {
> +      array[count] = current->return_address;
> +      current = BOUNDED_1 (current->next);
> +      if (!current)
> +	break;
> +    }
> +
> +  return count;
> +}
> +weak_alias (__backtrace, backtrace)
> +libc_hidden_def (__backtrace)
> diff --git a/sysdeps/sparc/sparc64/backtrace.c b/sysdeps/sparc/sparc64/backtrace.c
> new file mode 100644
> index 0000000..6d7e429
> --- /dev/null
> +++ b/sysdeps/sparc/sparc64/backtrace.c
> @@ -0,0 +1,58 @@
> +/* Return backtrace of current program state.
> +   Copyright (C) 2008 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +   Contributed by David S. Miller <davem@davemloft.net>
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Library General Public License as
> +   published by the Free Software Foundation; either version 2 of the
> +   License, or (at your option) any later version.
> +
> +   The GNU C Library is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   Library General Public License for more details.
> +
> +   You should have received a copy of the GNU Library General Public
> +   License along with the GNU C Library; see the file COPYING.LIB.  If not,
> +   write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
> +   Boston, MA 02111-1307, USA.  */
> +
> +#include <execinfo.h>
> +#include <stddef.h>
> +#include <bp-checks.h>
> +#include <sysdep.h>
> +
> +struct layout
> +{
> +  unsigned long locals[8];
> +  unsigned long ins[6];
> +  unsigned long next;
> +  void *__unbounded return_address;
> +};
> +
> +int
> +__backtrace (void **array, int size)
> +{
> +  struct layout *current;
> +  unsigned long fp;
> +  int count;
> +
> +  asm volatile ("flushw");
> +  asm volatile ("mov %%fp, %0" : "=r"(fp));
> +  current = (struct layout *__unbounded) (fp + STACK_BIAS);
> +  current = BOUNDED_1 (current);
> +
> +  for (count = 0; count < size; count++)
> +    {
> +      array[count] = current->return_address;
> +      if (!current->next)
> +	break;
> +      current = (struct layout *__unbounded) (current->next + STACK_BIAS);
> +      current = BOUNDED_1 (current);
> +    }
> +
> +  return count;
> +}
> +weak_alias (__backtrace, backtrace)
> +libc_hidden_def (__backtrace)
> -- 
> 1.5.5.1.57.g5909c
>