This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] PowerPC thread pointer bias requires powerpc/lowlevelrobustlock.sym
Benjamin Herrenschmidt wrote:
> On Thu, 2006-11-02 at 06:54 +0100, Fabio Massimo Di Nitto wrote:
>> Benjamin Herrenschmidt wrote:
>>> On Wed, 2006-11-01 at 18:14 -0600, Ryan S. Arnold wrote:
>>>> I've been sitting on this patch for way too long.
>>>>
>>>> The TID implementation in the default lowlevelrobustlock.sym is wrong
>>>> for PowerPC. The thread point on PowerPC is biased by -0x7000 to extend
>>>> the size of the FAST TLS to 64KB. This patch provides a powerpc
>>>> implementation to take this into account.
>>> Fabio, Jeff: That should fix the root cause of the errors on 2.6.18 and
>>> later for which my patch corrected the kernel oops (you would still have
>>> gotten an error from the syscall due to that glibc problem).
>>>
>>> Ben.
>>>
>> Perfect. I will apply in the next upload.
>
> Ryan, I might have done something wrong with my rebuild of the glibc-2.5
> (it might not have taken into account the new file, I really don't
> understand glibc build system), but I'm still getting the alignment
> error...
>
> I'm very busy with a lot of other things, so it's not easy for me do
> those tests especially considering how uncomfortable I am workin with
> glibc :) I'll try a fresh build from clean sources tomorrow and will see
> what's going on.
>
> Ben.
>
Hi Ben
i uploaded http://people.ubuntu.com/~fabbione/benh/glibc_2.5-0ubuntu2.d* that
apply the patch to the building tree.
Fabio
--
I'm going to make him an offer he can't refuse.