Re: [PATCH] vDSO for ppc/ppc64 submission

[Tom Gall <tom_gall at vnet dot ibm dot com>]

On Thu, 29 Dec 2005, Ulrich Drepper wrote:

> I've added the patch but had to change quite a lot.  It was less work to
> do it myself than to explain it but please compare the new code with
> your patch to see what should have been done.  A few notes I took:

Thanks. I'll have a look this weekend. Still in the thick of the holiday 
so time is unfortunately short today. 

Currently as is in CVS head doesn't even build for me, so I'd imagine 
there's some cleanup ahead. :-/
 
> 
> - copyright years were not updates.  Roland's upd-copyr.el does this
> automatically.

I'd be happy to use a version for vim ;-)

> - still many formatting errors.  Including the changelog.

Odd, is indent not implemented to the full set of coding standards? 

Which brings me to the gnits comment you had made a few weeks back. I'm 
happy to follow coding standards but they ought to be documented. The only 
gnits standard I could find online (least via google) is at :

http://www.amath.washington.edu/~lf/tutorials/autoconf/gnits/gnits.html

Tho largely when it comes to source standards, the document just points to 
the gnu standards document which is a bit incomplete in my opinion.

If gnits is the standard we ask people to aim for then shouldn't that be 
pointed to at say http://www.gnu.org/software/libc/resources.html ?

> - lots of whitespaces at end of lines.  In one case even after the
> backslash which is meant to continue a macro definition on the next
> line.  Use whitespace.el in emacs or equivalent tools for your editor

Very odd, vim and pine don't have a history of adding spaces. Looking back 
at the patch as it left here, I do just see one instance of a space after 
a backslash. 

<snip for further analysis tomorrow>

Regards,

Tom