Re: m32r-linux add-on ports of glibc

[Roland McGrath <roland at redhat dot com>]

> I will stop posting a giant patch.

Thanks.

> I will report by the following site.
> http://www.linux-m32r.org/

I've looked at your patch there.  There are some typos and mistaken
file/directory names in your ChangeLog.m32r file.  You might want to check
it over.

The preconfigure file you have is not appropriate.  The purpose of the
preconfigure file is really only if it's needed to set $machine et al,
which is only the case if config.sub doesn't always output the right one
string (and you don't have machine variant subdirs you want to use).  Your
port does not need a preconfigure script at all.

Your sysdeps/m32r/preconfigure file just does some generic check.  It
should be done in the later phase on figure, i.e. in a "configure" file not
a "preconfigure" file.  Furthermore, you provided a preconfigure without a
preconfigure.in, and hard-coded autoconf internals in it.  What you should
really have is a sysdeps/m32r/configure.in that uses AC_DEFINE, and a
sysdeps/m32r/configure generated from that.  Take a look at the scripts
I've just added to ports/sysdeps/cris as the model.  

The natural way to distribute an individual add-on port is not as a patch,
but as an add-on tar file.  Make a tar file including your new sysdeps
directories, ChangeLog.m32r, and the few top-level script files from the
ports directory (configure, configure.in, Makefile, Makeconfig), and a
Banner file if you like.  This is something that your users can drop into
glibc just like the ports add-on.  

I haven't yet looked at your port's code itself.  

> > Have you done the FSF copyright assignment?
> Yes, I have. It's for glibc.
> I received it at 9 Feb. 2004.

Great.  I've checked your name in the file and everything is fine for all
your current and future contributions.  Thanks for taking care of the legal
paperwork early, so that will never be an obstacle for your future work.


Thanks,
Roland