This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
glob.c:glob_in_dir case fold for W32
- From: Alessandro Vesely <vesely at tana dot it>
- To: libc-alpha at sources dot redhat dot com
- Cc: "Paul D. Smith" <psmith at gnu dot org>
- Date: Thu, 29 Jul 2004 10:54:10 +0200
- Subject: glob.c:glob_in_dir case fold for W32
Hi,
I'd like to propose a 1-liner update as follows:
--- glibc-2.3.2/sysdeps/generic/glob.c 2003-01-17 01:21:12.000000000 +0100
+++ glob.c 2004-07-29 07:44:06.000000000 +0200
@@ -1339,7 +1339,7 @@
{
int fnm_flags = ((!(flags & GLOB_PERIOD) ? FNM_PERIOD : 0)
| ((flags & GLOB_NOESCAPE) ? FNM_NOESCAPE : 0)
-#if defined _AMIGA || defined VMS
+#if defined _AMIGA || defined VMS || defined HAVE_CASE_INSENSITIVE_FS
| FNM_CASEFOLD
#endif
);
AFAIK, HAVE_CASE_INSENSITIVE_FS is only defined in GNU make, which uses that function.
The reason I propose the update is so that make's `$(wildcard stuff)', which in turn
calls glob_in_dir, would work properly on win32 even if one doesn't specify the exact
case of `stuff'.
I think HAVE_CASE_INSENSITIVE_FS is better than, say, WINDOWS32. However, adding the
latter would be an equivalent fix for my concern.
Thank you for your attention
Keep up the good work!
a user