This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: ffsl on s390x must fail
On Fri, Apr 09, Thorsten Kukuk wrote:
> On Fri, Apr 09, Thorsten Kukuk wrote:
>
> >
> > Hi,
> >
> > test-ffs fails on s390x. No wonder because s390x uses the s390
> > implementation, and int is not equal to long on s390x.
> > But on s390x, ffsl is a weak alias to ffsll and to _ffs. And
> > it seems the wrong weak alias wins.
>
> Here is a fix for it:
Sorry, but I missed one line in the patch, else it cannot work:
2004-04-13 Thorsten Kukuk <kukuk@suse.de>
* sysdeps/s390/ffs.c: Include limits.h
--- sysdeps/s390/ffs.c 9 Apr 2004 18:23:13 -0000 1.5
+++ sysdeps/s390/ffs.c 13 Apr 2004 08:37:46 -0000
@@ -19,6 +19,7 @@
Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
02111-1307 USA. */
+#include <limits.h>
#define ffsl __something_else
#include <string.h>
--
Thorsten Kukuk http://www.suse.de/~kukuk/ kukuk@suse.de
SuSE Linux AG Maxfeldstr. 5 D-90409 Nuernberg
--------------------------------------------------------------------
Key fingerprint = A368 676B 5E1B 3E46 CFCE 2D97 F8FD 4E23 56C6 FB4B