This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Linuxthreads PPC64 sysdep-cancel.h


Steve Munroe <sjmunroe@us.ibm.com> writes:

> The SINGLE_THREAD_P test is still defined using the static field
> __local_multiple_threads which is less efficient then the thread local
> reference to the p_multiple_threads field. Also as Jimi Xenidis points
> out, the current code is incorrectly loading a int flag as a
> doubleword. The attached patch replaces the two definitions of
> SINGLE_THREAD_P with thread local test.
>
> 2003-12-04  Steven Munroe  <sjmunroe@us.ibm.com>
>
> 	* sysdeps/unix/sysv/linux/powerpc/powerpc64/sysdep-cancel.h 
> 	(SINGLE_THREAD_P): Test using thread local p_multiple_threads field.

This patch is broken since now glibc will no longer bootstrap since we
have in linuxthreads/sysdeps/powerpc/tls.h:

/* Make sure we have the p_multiple_threads member in the thread structure.
   See below.  */
#  ifndef __powerpc64__
#   define TLS_MULTIPLE_THREADS_IN_TCB 1
#  endif

We're currently testing a patch that defines
TLS_MULTIPLE_THREADS_IN_TCB also on powerpc64.  Or do you propose
another solution?

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SuSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]