This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
[PATCH RFA] remove MIPS setting of __libc_stack_end.
- From: cgd at broadcom dot com
- To: libc-alpha at sources dot redhat dot com
- Cc: jakub at redhat dot com
- Date: 29 Sep 2003 11:23:50 -0700
- Subject: [PATCH RFA] remove MIPS setting of __libc_stack_end.
Looks like this was done for a bunch of other arches in:
http://sources.redhat.com/ml/libc-hacker/2003-09/msg00083.html
but not MIPS. I ran into some other problems after that patch
(couldn't just install glibc into / easily; had to install elsewhere
then tar/untar), so that patch caught my attention
I figured i'd remove the code in the mips dl-machine.h which sets
__libc_stack_end, since it hadn't been done for MIPS. (I don't really
understand the motivation for the change, don't care to... But it
looked like a very simple change for other arches, and MIPS looked
similarly simple. 8-)
Anyway, here's the patch. It's been tested on glibc sources as of
2003-09-29 06:50 UTC, configure/make/check/install on mips64 native,
for each of o32, n32, and n64. (the source tree also my two other
n32/n64 patches applied, which are still waiting. 8-)
Seems to work fine.
chris
--
2003-09-29 Chris Demetriou <cgd@broadcom.com>
* sysdeps/mips/dl-machine.h (RTLD_START): Remove setting of
__libc_stack_end.
Index: sysdeps/mips/dl-machine.h
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/mips/dl-machine.h,v
retrieving revision 1.69
diff -u -p -r1.69 dl-machine.h
--- sysdeps/mips/dl-machine.h 31 Jul 2003 06:33:52 -0000 1.69
+++ sysdeps/mips/dl-machine.h 29 Sep 2003 17:13:54 -0000
@@ -481,8 +481,6 @@ _dl_start_user:\n\
move $16, $28\n\
# Save the user entry point address in a saved register.\n\
move $17, $2\n\
- # Store the highest stack address\n\
- " STRINGXP(PTR_S) " $29, __libc_stack_end\n\
# See if we were run as a command with the executable file\n\
# name as an extra leading argument.\n\
lw $2, _dl_skip_args\n\