This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch: Make sort-test handle more then 100 lines, and avoid segfault


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Petter Reinholdtsen wrote:

> 2003-07-13  Petter Reinholdtsen  <pere@hungry.com>
> 
> 	* collate-test.c (main): Correct handling of files with more then
> 	100 lines. Print error message if argument is missing, instead of
> 	segfaulting.  Avoid memleak in test code.
> 	* xfrm-test.c: Likewise.

I've applied the patch, thanks.

Just one thing: not freeing memory before it terminates is no memory
leak.  It is usually stupid to do this since it unnecessarily slows down
the program.  But I added the changes here since this is a test program
and the free() calls can detect memory corruption.  So this is acceptable.

- -- 
- --------------.                        ,-.            444 Castro Street
Ulrich Drepper \    ,-----------------'   \ Mountain View, CA 94041 USA
Red Hat         `--' drepper at redhat.com `---------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE/E8Kn2ijCOnn/RHQRAjo7AJ9nHl2Wsh1PSDl3jBjTwOM+um637ACfRCFx
PYuuejYDysND8T/SwDyLF0M=
=JCbn
-----END PGP SIGNATURE-----


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]