This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: PATCH: return signed result of syscall for cris
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: libc-alpha at pulsar dot homelinux dot net
- Cc: libc-alpha at sources dot redhat dot com, hans-peter dot nilsson at axis dot com
- Date: Fri, 13 Jun 2003 17:50:53 +0200
- Subject: Re: PATCH: return signed result of syscall for cris
> Date: Fri, 13 Jun 2003 17:11:36 +0200
> From: Uwe Reimann <libc-alpha@pulsar.homelinux.net>
> this patch makes llseek() return -1LL instead of 0xffffffff when in case
> of an error (for sources which use -D_FILE_OFFSET_BITS=64).
>
> This works for me. Hans-Peter, any comments?
Thank you very much for finding the bug! The patch looks ok,
with a nit: formatting at end of line and the changelog entry
(see other changelog entries).
> P.S.: Is there an easier way to incoporate the comments into the patch
> than editing it manually?
I don't think I understand what you say here. If you refer to
writing changelog-entries, I don't do that. I use Emacs and the
equivalent of M-x add-change-log-entry while at the point of the
change, which takes care of most of the work of proper
formatting of the entry. And please use "cvs diff -up" or "cvs
diff -cp" for patches; the default format you used isn't usable
as input to the "patch" program. I guess the glibc projects has
guidelines somewhere; if not check
<URL:http://gcc.gnu.org/contribute.html>. I suggest you put
"diff -u -p" in your "~/.cvsrc".
brgds, H-P