This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PPC64 Linuxthreads tls.h M2


> This code in sysdeps/powerpc/powerpc64/dl-machine.h looks wrong to me

Indeed.  I hadn't checked that code closely too before putting it in,
since sjmunroe said it worked and I don't know much about powerpc.

It's clearly wrong.  I fixed and cleaned up some of that code.
Please take a look at what's in CVS now.

However, looking at the code and the spec now I see it has other bogons.
The code for {TPREL,DTPREL}16_* is clearly wrong.  Those cases need to use
the same calculations R_PPC64_TPREL64 and R_PPC64_DTPREL64 use for the full
values before using some bits out of them.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]