This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: [PATCH] regex performance improvement
- From: Ulrich Drepper <drepper at redhat dot com>
- To: Isamu Hasegawa <isamu at yamato dot ibm dot com>
- Cc: Jakub Jelinek <jakub at redhat dot com>, Roland McGrath <roland at redhat dot com>, Paolo Bonzini <bonzini at gnu dot org>, Jack Howarth <howarth at bromo dot med dot uc dot edu>, libc-alpha at sources dot redhat dot com
- Date: Fri, 22 Nov 2002 12:26:11 -0800
- Subject: Re: [PATCH] regex performance improvement
- References: <u7kf72hpt.wl@AMBER.yamato.ibm.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Isamu Hasegawa wrote:
> Originally, I intended to submit my patch after the patch will be complete.
> However, it is inefficient to adapt my development version to the cvs
> each time. Then I'd like to submit a patch bit by bit when it is ready.
That's certainly a good idea. Whenever intermediate versions are
working fine you should send them.
As for this specific patch: in general it looks good. I'd like to see a
few more comments, especially before function definitions explaining the
purpose of functions.
There are also some more critical problems. You're using memory
allocation results without checking for NULL results.
- --
- --------------. ,-. 444 Castro Street
Ulrich Drepper \ ,-----------------' \ Mountain View, CA 94041 USA
Red Hat `--' drepper at redhat.com `---------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)
iD8DBQE93pLj2ijCOnn/RHQRAmskAKCjqNvjUXBN/ypzgMnoiNvg0s296wCgzSsR
SSgsATnOf8UqOonpb/Kt/hc=
=coSm
-----END PGP SIGNATURE-----