This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] add ppc64 specific code


Roland McGrath wrote:

> The function dl_reloc_overflow needs to be named _dl_reloc_overflow
> instead.  Rather than using asm's with .hidden, you should just use
> attribute_hidden on the extern decl in dl-machine.h.

OK I'll take a look at this. On the .hidden the gcc-3.2 may not
have all support for this. Full support is promised for gcc-3.3.

> Please fix those things and resend this patch (I could add the other
files,
> but I will wait for you to resend the whole set from this message in case
> you have further tweaked some other files).

OK, I'll need to do a quick forward port to current cvs first then create
new patch.




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]